Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[baseserver] Stop logging healthcheck RPCs #10419

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jun 2, 2022

Description

Fixes spam logging of

{"grpc.code":"OK","grpc.method":"Check","grpc.request.deadline":"2022-06-01T21:49:38Z","grpc.service":"grpc.health.v1.Health","grpc.start_time":"2022-06-01T21:49:33Z","grpc.time_ms":0.035,"level":"info","message":"
finished unary call with code OK","serviceContext":{"service":"ws-daemon","version":"commit-bfcb0a9574f8c994f9d80615c7b5ed6e1fc839ac"},"severity":"INFO","span.kind":"server","system":"grpc","time":"2022-06-01T21:49
:33Z"}                                                                                                                                                                                                                

When healthcheck is accessed frequently.

Related Issue(s)

Fixes #

How to test

Unit test
When running unit tests, notice health check logs are not printed

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested review from a team June 2, 2022 06:14
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 2, 2022
@roboquat roboquat added the size/S label Jun 2, 2022
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 2, 2022
@easyCZ easyCZ force-pushed the mp/baseserver-skip-healthcheck branch from 5a10d8b to ec85ab5 Compare June 2, 2022 06:16
@roboquat roboquat added size/XS and removed size/S labels Jun 2, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jun 2, 2022

/werft run

👍 started the job as gitpod-build-mp-baseserver-skip-healthcheck.2
(with .werft/ from main)

@roboquat roboquat merged commit 4431375 into main Jun 2, 2022
@roboquat roboquat deleted the mp/baseserver-skip-healthcheck branch June 2, 2022 07:02
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jun 9, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants