Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MinI, MySQL and RabbitMQ helm dependencies to latest version #10428

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jun 2, 2022

Description

We were using a very outdated MinIO, MySQL and RabbitMQ helm chart version. These version have become unavailable since. This PR bumps the helm charts to their latest version.

image

How to test

cd install/installer/third_party/charts/minio
helm dep update
cd ../mysql
helm dep update
cd ../rabbitmq
helm dep update

Release Notes

[installer] Bump MinIO helm chart to 11.6.3
[installer] Bump MySQL helm chart to 9.1.2
[installer] Bump RabbitMQ helm chart to 10.1.1

@csweichel csweichel requested a review from a team June 2, 2022 09:37
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 2, 2022
@csweichel csweichel changed the title Bump minio to existing version Bump MinIO and MySQL helm dependencies to latest version Jun 2, 2022
@mrsimonemms
Copy link
Contributor

Do we need to test this with a self-hosted in-cluster instance or have you done that?

I suspect I'll need to do a new hotfix release for the Installer/KOTS as a result of this. I'll do that job

Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold holding in case of new changes, but lgtm. Release when you're ready

@csweichel
Copy link
Contributor Author

Do we need to test this with a self-hosted in-cluster instance or have you done that?

Yes, we do

I suspect I'll need to do a new hotfix release for the Installer/KOTS as a result of this. I'll do that job

I don't think so - we're shipping the helm charts embedded in the installer.
This just breaks our builds.

@mrsimonemms
Copy link
Contributor

Ok, I'll do the test in the self-hosted instance now and approve when it's good

@mrsimonemms mrsimonemms self-requested a review June 2, 2022 09:42
@roboquat roboquat added size/S and removed size/XS labels Jun 2, 2022
@csweichel csweichel changed the title Bump MinIO and MySQL helm dependencies to latest version Bump MinI, MySQL and RabbitMQ helm dependencies to latest version Jun 2, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my self-hosted instance and works fine - did a full image build in a fresh instance

@csweichel
Copy link
Contributor Author

/hold cancel

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Jun 2, 2022

Ooops, didn't realise it was still on hold 😊

@roboquat roboquat merged commit b6f4557 into main Jun 2, 2022
@roboquat roboquat deleted the cw/bump-minio branch June 2, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants