-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[previewctl] Improve logging #10436
[previewctl] Improve logging #10436
Conversation
@@ -8,16 +8,17 @@ import ( | |||
"fmt" | |||
|
|||
"github.com/gitpod-io/gitpod/previewctl/pkg/preview" | |||
"github.com/go-kit/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All code in Gitpod uses logrus
- we even tie klog
(used by Kubernetes components) back to logrus.
What's the motivation to go astray? I.e. which requirements warrant the use of a different library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None really, just wanted to move away from the previous 馃檪
I'll update the PR to logrus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best use common-go/log
, but using logrus directly is fine, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe adopting a big lib just for one of the features may be too much.
I've only switched to logrus for now, but if someday in the future we need tracing/metrics/pprof, then common-go sounds like a good idea 馃檪
c45c5a6
to
2203c43
Compare
Switched log library to Logrus Signed-off-by: ArthurSens <arthursens2005@gmail.com>
2203c43
to
734bff4
Compare
Description
To improve experience while debugging when previewctl is not behaving as it should, this PR does 2 things:
install-context --watch
fails to install and goes for another loopHow to test
previewctl install-context --watch
You'll notice that the watch still doesn't work as expected (for me it stops looping at some point), but at least now we know what is happening 馃槄
Release Notes