Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspace integration test #10512

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Fix workspace integration test #10512

merged 6 commits into from
Jun 10, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 8, 2022 •
edited

Description

  • Fix the pipestatus is always 0 even the go test failure.
  • Remove the parallel run to avoid too many request issues when starting the workspace
  • Correct the output log

Related Issue(s)

Fixes #10544

How to test

werft run github -j .werft/workspace-run-integration-tests.yaml

Release Notes

None

Documentation

N/A

@jenting jenting force-pushed the jenting/fix-incorrect-pipestatus branch 2 times, most recently from db981f7 to cd6c370 Compare June 8, 2022 05:35
@roboquat roboquat added size/M and removed size/S labels Jun 8, 2022
@jenting jenting force-pushed the jenting/fix-incorrect-pipestatus branch 2 times, most recently from e03d0d1 to e8e85a0 Compare June 8, 2022 06:51
@jenting jenting force-pushed the jenting/fix-incorrect-pipestatus branch from e375f02 to e8e85a0 Compare June 9, 2022 07:48
@roboquat roboquat added size/S and removed size/M labels Jun 9, 2022
@jenting
Copy link
Contributor Author

jenting commented Jun 9, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jenting-fix-incorrect-pipestatus.12
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Jun 9, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jenting-fix-incorrect-pipestatus.13
(with .werft/ from main)

@jenting
Copy link
Contributor Author

jenting commented Jun 9, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jenting-fix-incorrect-pipestatus.14
(with .werft/ from main)

@jenting
Fix incorrect pipestatus
2b77bf5 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Disable parallel tests to avoid too many requests
4198f10 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Fix output log incorrect
dc880d4 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Fix broken test case
66987cf 
The branch naming rule changed.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Remove duplicate wait workspace to start
181d2cf 
The function integration.LaunchWorkspaceFromContextURL waits the
workspace to start already.

Ref to https://github.com/gitpod-io/gitpod/blob/66ba0b10b55fabeb396e6d2147bb8307315dc008/test/pkg/integration/workspace.go#L264

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting
Move file under pkg/integration folder
2c3df5c 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/fix-incorrect-pipestatus branch from e8e85a0 to 2c3df5c Compare June 10, 2022 01:09
@jenting
Copy link
Contributor Author

jenting commented Jun 10, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-jenting-fix-incorrect-pipestatus.16
(with .werft/ from main)

@jenting jenting marked this pull request as ready for review June 10, 2022 02:25
@jenting jenting requested a review from a team June 10, 2022 02:25
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 10, 2022
@roboquat roboquat merged commit e88fd7e into main Jun 10, 2022
@roboquat roboquat deleted the jenting/fix-incorrect-pipestatus branch June 10, 2022 03:27
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workspace nightly integration test hits too many requests when creating the workspace
3 participants
@jenting @sagor999 @roboquat