-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blobserve router under ide-proxy #10513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the following URL, it should be work, and check the response header, Cache-Control should be set public, max-age=31536000
Why we should (can only) test those three URLs below?
These are just an example, in fact I'm just giving the format here, just make sure the various formats above are compatible PS: You can simple test this PR #10514, This contains the effect of the change |
Thank you for your clarification 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR is 1st part of move blobserve behind ide proxy #7986
This PR contain follow things
read only mode
see comment for detail move blobserve behind ide proxy #7986 (comment), simple not execute, didn't remove logic, in case we need add this backX-BlobServe-InlineVars
and HTTP method is notGET
, set cache max-age to 31536000, otherwise isno-cache
HEAD
method for warm-up cacheRelated Issue(s)
Relate #7986
How to test
You can simple test this PR #10514, it contains the effect of the change in this PR
Cache-Control
should be setpublic, max-age=31536000
X-BlobServe-InlineVars
works, diff response body with removeX-BlobServe-InlineVars
header, the difference should like https://www.diffchecker.com/iBzZcjRj ,this is becausegitpod/install/installer/pkg/components/blobserve/configmap.go
Lines 74 to 89 in 86b2b9e
curl -v --head "https://ide.pd-move-blob-2.preview.gitpod-dev.com/blobserve/eu.gcr.io/gitpod-core-dev/build/ide/code:commit-80d9b1ebfd826fd0db25320ba94d762b51887ada/index.html"
, it should not response body, only HTTP statusRelease Notes
Documentation