Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update gitpod dev image" #10522

Merged
merged 3 commits into from
Jun 8, 2022
Merged

Revert "Update gitpod dev image" #10522

merged 3 commits into from
Jun 8, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Jun 8, 2022

Reverts #10509

The build and workspaces are failing with protoc-gen-js: program not found or is not executable. There are two reasons the build on the original PR might not have caught this

  • We have job protection enabled, so by default jobs triggered by Werft uses the job specs from main
  • The build didn't rebuild all components. Notably components/supervisor-api/typescript-grpc:lib and components/supervisor-api/typescript-grpcweb:lib weren't build as part of the job and they are the ones failing on main.

To get a successful build I used the following command to make sure that Werft runs using the changes off my branch and that it updates the commit check as part of the job. Using no-test and no-preview just to speed up the job.

werft job run github -a updateGitHubStatus=gitpod-io/gitpod -a no-test=true -a no-preview=true 

NOTE: I don't know how to trigger Leeway to build all components and my build doesn't contain the components that break on main. But when I open a workspace off this branch the build works, and it doesn't on main so I think we should merge this. The following two commands works in a workspace off this branch but not on main:

leeway build components/supervisor-api/typescript-grpcweb:lib
leeway build leeway build components/supervisor-api/typescript-grpc:lib

Release Notes

NONE

Documentation

N/A

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat merged commit beb9ed6 into main Jun 8, 2022
@roboquat roboquat deleted the revert-10509-aledbf/go183 branch June 8, 2022 09:10
@roboquat roboquat added the deployed: IDE IDE change is running in production label Jun 9, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants