Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitpod dev image #10529

Merged
merged 4 commits into from
Jun 8, 2022
Merged

Update gitpod dev image #10529

merged 4 commits into from
Jun 8, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 8, 2022

Description

Rollback protoc to v3.20.1

Related Issue(s)

How to test

  • Check server build do not return errors

Release Notes

NONE

Documentation

@aledbf aledbf force-pushed the aledbf/go183.2 branch 2 times, most recently from 1373532 to f39b7fe Compare June 8, 2022 11:36
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@aledbf
Copy link
Member Author

aledbf commented Jun 8, 2022

Successful build without cache https://werft.gitpod-dev.com/job/gitpod-build-aledbf-go183.2.3/logs

@aledbf aledbf marked this pull request as ready for review June 8, 2022 11:40
@aledbf aledbf requested review from a team June 8, 2022 11:40
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels Jun 8, 2022
felladrin
felladrin approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've also run a workspace in VS Code Browser and IntelliJ IDEA in the preview environment. All good!

mads-hartmann
mads-hartmann approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I opened up a workspace from this branch and leeway build components/supervisor-api/typescript-grpc:lib does indeed work (this is one of the components that broke the last time)

@roboquat roboquat merged commit 86282e8 into main Jun 8, 2022
@roboquat roboquat deleted the aledbf/go183.2 branch June 8, 2022 17:09
@roboquat roboquat added the deployed: IDE IDE change is running in production label Jun 9, 2022
@mads-hartmann mads-hartmann mentioned this pull request Jun 9, 2022
Closed
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

@felladrin felladrin felladrin approved these changes

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aledbf @mads-hartmann @felladrin @sagor999 @roboquat