Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret to preview environments #10552

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jun 9, 2022

Description

Following on from https://github.com/gitpod-io/ops/pull/2696 in which a secret was added to the Werft cluster for core-dev, this PR copies the secret from Werft into the k3s cluster for preview environments during deployment of each preview env.

This process ensures that we get a secret containing Stripe API keys into preview environments, without the secret touching source control.

Related Issue(s)

Part of #9036

How to test

Manually trigger a werft job for this branch (Notion doc).

Within the cluster for the preview environment, verify that there is now a secret called stripe-api-keys:

kubectl get secret stripe-api-keys

NAME              TYPE     DATA   AGE
stripe-api-keys   Opaque   1      5m53s

You may have to create

Release Notes

NONE

Documentation

@andrew-farries andrew-farries marked this pull request as draft June 9, 2022 20:37
@andrew-farries andrew-farries force-pushed the af/create-stripe-secret-in-preview-env branch from 97c6a59 to 6248fa1 Compare June 10, 2022 09:26
@andrew-farries andrew-farries marked this pull request as ready for review June 10, 2022 09:56
@andrew-farries andrew-farries force-pushed the af/create-stripe-secret-in-preview-env branch from 6248fa1 to c64d341 Compare June 13, 2022 09:07
Andrew Farries added 3 commits June 13, 2022 20:18
@roboquat roboquat requested a review from a team June 13, 2022 14:48
@roboquat roboquat added size/M and removed size/S labels Jun 13, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 13, 2022
@andrew-farries andrew-farries removed the request for review from mads-hartmann June 13, 2022 15:38
@jankeromnes jankeromnes self-assigned this Jun 13, 2022
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @andrew-farries! 🙏

I got a bit confused due to the two merged PRs, but I tested everything again and it still seems to work. 🎉 (Maybe this could have been a single PR, so that I could have reviewed/tested it only once? 🤔)

@roboquat roboquat merged commit e9e33d8 into main Jun 13, 2022
@roboquat roboquat deleted the af/create-stripe-secret-in-preview-env branch June 13, 2022 16:02
@andrew-farries
Copy link
Contributor Author

andrew-farries commented Jun 13, 2022

I got a bit confused due to the two merged PRs, but I tested everything again and it still seems to work. 🎉 (Maybe this could have been a single PR, so that I could have reviewed/tested it only once? 🤔)

Yeah, sorry. I was hoping that this one would get merged quickly first. They ended up getting done in the wrong order 😄

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants