Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Stripe API clean-up #10554

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Minor Stripe API clean-up #10554

merged 1 commit into from
Jun 9, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Jun 9, 2022 •
edited

Description

  • Make getStripePublishableKey always return a string, or throw an error if there is no key
  • Make getStripeSetupIntentClientSecret always return a string, or throw an error if the SetupIntent doesn't have a client secret
  • Rename getTeamStripeCustomerId to findTeamStripeCustomerId (to clarify that it can be undefined)

Related Issue(s)

Fixes #

How to test

  • Should still build

Release Notes

NONE

Documentation

  • /werft with-payment

@jankeromnes jankeromnes changed the title [server][dashboard] Minor Stripe API clean-up Minor Stripe API clean-up Jun 9, 2022
@jankeromnes jankeromnes marked this pull request as ready for review June 9, 2022 11:46
@jankeromnes jankeromnes requested a review from a team June 9, 2022 11:46
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 9, 2022
easyCZ
easyCZ approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the changes!

@ArthurSens
Copy link
Contributor

ArthurSens commented Jun 9, 2022 •
edited by werft-gitpod-dev-com bot

/hold

This PR is currently blocking the merge queue. The problem is not the changes here, but a bug we introduced to main 😅 The PR fixing it was already approved, but we need to get your PR from the queue to get it merged... could you rebase and remove the hold after that? 🙏

@jankeromnes
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 497741d into main Jun 9, 2022
@roboquat roboquat deleted the jx/stripe-cleanup branch June 9, 2022 15:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jankeromnes @ArthurSens @easyCZ @roboquat