Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registry facade not being able to start up in preview environment #10556

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Jun 9, 2022

Description

Remove ownerReferences as they still reference the old secret name, which makes Kubernetes accept the creation of the secret, but then it vanishes without a trace. Registry-facade then tries to mount the non existing secret.

 ownerReferences:
  - apiVersion: cert-manager.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: Certificate
    name: harvester-fo-ws-class-env
    uid: 1ab08d7c-78f2-43ae-ad3a-fc0a67d06bde

Related Issue(s)

n.a.

How to test

Preview environment should get into ready state

Release Notes

NONE

@Furisto
Copy link
Member Author

Furisto commented Jun 9, 2022

The last build is green: https://werft.gitpod-dev.com/job/gitpod-custom-fo-remove-owner-refs.2
The checks show the wrong status.

@kylos101 kylos101 requested a review from a team June 9, 2022 13:31
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 9, 2022
@Furisto
Copy link
Member Author

Furisto commented Jun 9, 2022

/werft run

👍 started the job as gitpod-build-fo-remove-owner-refs.1
(with .werft/ from main)

@Furisto
Copy link
Member Author

Furisto commented Jun 9, 2022

/werft run -j .werft/build.yaml -s .werft/util/certs.ts -f -a with-clean-slate-deployment=true

@Furisto
Copy link
Member Author

Furisto commented Jun 9, 2022

/werft run -j .werft/build.yaml -s .werft/util/certs.ts -f -a with-clean-slate-deployment=true

👍 started the job as gitpod-build-fo-remove-owner-refs.2
(with .werft/ from main)

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vulkoingim
Copy link
Contributor

vulkoingim commented Jun 9, 2022

/werft run github -j ./werft/build.yaml -s .werft/util/certs.ts -a updateGitHubStatus=gitpod-io/gitpod

👍 started the job as gitpod-build-fo-remove-owner-refs.3
(with .werft/ from main)

@Furisto
Copy link
Member Author

Furisto commented Jun 9, 2022

/werft run github -j ./werft/build.yaml -s .werft/util/certs.ts -a updateGitHubStatus=gitpod-io/gitpod

👍 started the job as gitpod-build-fo-remove-owner-refs.4
(with .werft/ from main)

@roboquat roboquat merged commit dbd8d6b into main Jun 9, 2022
@roboquat roboquat deleted the fo/remove-owner-refs branch June 9, 2022 14:28
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants