-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jb]: monitor low memory notifications #10558
Conversation
d5c9f50
to
63b46f1
Compare
63b46f1
to
2fa004d
Compare
82297cd
to
ccab38d
Compare
started the job as gitpod-build-ak-jb-gc-pause.20 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.21 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.22 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.23 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.24 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.25 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.26 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.27 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.28 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.29 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.30 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.31 because the annotations in the pull request description changed |
ccab38d
to
617f257
Compare
started the job as gitpod-build-ak-jb-gc-pause.33 because the annotations in the pull request description changed |
started the job as gitpod-build-ak-jb-gc-pause.34 because the annotations in the pull request description changed |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-ak-jb-gc-pause.35 |
started the job as gitpod-build-ak-jb-gc-pause.36 because the annotations in the pull request description changed |
@mustard-mh Could you have a look please? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
/hold
Not sure if I need to test with observability too? Since we can see it in dev Grafana
dev Grafana should be enough
First graph show overall in the system (among all pods) how many low memory cases happen. Second show top 10 pods with highest number of notifications. First graph should be clean ideally. Second should be used to investigate worst cases.
Yes, it does not work. I will file an issue to investigate how to fix it. |
/unhold |
a follow-up to upgrade of Xmx: #10715 |
Description
As for now we monitor JVM used and max memory. It is not enough though to detect perf degradation, since GC can kick off and release memory. It turned out though that JB backend already monitors performance degradation internally and notifies a user about it with low memory notification after GC. This PR adds a counter of low memory notifications. Steady increase of such notifications means performance degradation for a user.
Related Issue(s)
Monitoring for #8704
How to test
Reproducing low memory notifications
LanguageServerImpl.java
fileMonitoring
./dev/preview/portforward-monitoring-satellite.sh -c harvester
to port forward prometheus API endpoint.gp preview $(gp url 3000)/d/oamBLUC7k/jetbrains-overview?orgId=1 --external
to open JetBrains Overview dashboard.Release Notes
Documentation