Update platform version from 'gateway-plugin' to target JetBrains Gateway v2022.2-Nightly #10592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felladrin
force-pushed
the
felladrin/update-gw-platform
branch
from
739817a
to
851652c
Compare
felladrin
changed the title
felladrin
changed the title
mustard-mh
reviewed
Jun 13, 2022
There was a problem hiding this comment.
I tried with Gateway v2022.1.x, install failed as expected.
But
- Gateway
2022.2 EAP, connect to workspace not works (my host isgitpod.io) which workspace connect well with2022.1.3and0.0.1-main.3498 - Gateway
2022.2 EAPwith plugin Gitpod0.0.1-main.3498works well
Maybe we missed some changes for breaking change of APIs
| Plugin Installed | Connect Failed |
|---|---|
 |
 |
Thanks for reviewing it @mustard-mh! |
felladrin
force-pushed
the
felladrin/update-gw-platform
branch
from
851652c
to
611aec4
Compare
felladrin
changed the title
felladrin
force-pushed
the
felladrin/update-gw-platform
branch
from
611aec4
to
d65fe4d
Compare
felladrin
force-pushed
the
felladrin/update-gw-platform
branch
from
d65fe4d
to
f0f6be7
Compare
|
Updated and ready for review. Note: Now it will work only with Gateway v222.3048.1 or later. |
|
What is the state of this PR? @felladrin @mustard-mh |
mustard-mh
approved these changes
Jun 17, 2022
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update platform version from 'gateway-plugin' to the nightly (com.jetbrains.gateway: 222-NIGHTLY-CUSTOM-SNAPSHOT), to make use of the latest API.
Also, update the minimum version of the plugin to 222.3048.1, so it can only be installed on new gateway versions (2022.2+) downloaded from https://www.jetbrains.com/remote-development/gateway/ after June 16 2022.
Gateway 2022.1 (221) will is not going to receive new features.
Related Issue(s)
Follow-up for #10505
How to test
Release Notes
Documentation