Use xterm-256color when creating terminal
#10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any difference but It would be good to use the same value as vscode nonetheless |
|
@jeanp413 is there any difference, or is it maybe just an alias? Is there a different amount of colors supported with I agree that it's good to have it like VS Code does. |
mustard-mh
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Tested good.
It's quite different in MacOS for both browser and desktop,
maybe you can test with msgcat too, cc @filiptronicek @jeanp413
sudo apt-get update
sudo apt-get install -y gettext
|
Cool, thanks @mustard-mh 🚀 |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
xterm-256colorwhen creating pty terminalHow to test
echo $TERMin a task terminal it should outputxterm-256colorRelease Notes