Refactor 'normalizedContextURL' property from Java class 'WorkspaceContext' as Optional #10596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it can come null from the server, as you can see on interface WorkspaceContext from `components/gitpod-protocol/src/protocol.ts`.
mustard-mh
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Test good in Gateway 2022.1.3
| Img |
|---|
 |
I build a prev env which makes server.getWorkspaces and server.getWorkspace API respond without field normalizedContextURL, and it works well too
gitpod/components/server/src/workspace/gitpod-server-impl.ts
Lines 834 to 837 in 5f12b12
| Workspaces | Connection |
|---|---|
 |
 |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor 'normalizedContextURL' property from Java class 'WorkspaceContext' as Optional, because it can come null from the server, as you can see on the interface WorkspaceContext from
components/gitpod-protocol/src/protocol.ts.gitpod/components/gitpod-protocol/src/protocol.ts
Line 885 in 40158ac
Related Issue(s)
Issue raised by @mustard-mh in #10377 (review)
How to test
I haven't seen a case where the 'normalizedContextURL' of a workspace was null. And don't know if we can simulate it, but following the same
How to testfrom #10377 should show it's working as expected. The difference is that we should use the gateway-plugin build generated by this PR instead.Release Notes
Documentation