Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-manager] change workspace state tracing #10597

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[ws-manager] change workspace state tracing #10597

merged 1 commit into from
Jun 14, 2022

Conversation

sagor999
Copy link
Contributor

Description

As discussed in #10264 (comment)

Related Issue(s)

Fixes #10590

How to test

Release Notes

none

Documentation

@sagor999
Copy link
Contributor Author

@csweichel @mads-hartmann
this creates new spans now, instead of attaching to closed one.
Let me know if you agree on the approach. Not sure if we still wanted to somehow link new span to original span or leave it completely detached. 🤔
Will leave this PR in draft while awaiting feedback.

csweichel
csweichel approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! One step closer to better traces :)

Left two nits, hence the hold.

/hold

components/ws-manager/pkg/manager/imagespec.go Outdated Show resolved Hide resolved
components/ws-manager/pkg/manager/monitor.go Show resolved Hide resolved
@sagor999 sagor999 marked this pull request as ready for review June 13, 2022 18:08
@sagor999 sagor999 requested review from a team June 13, 2022 18:08
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Jun 13, 2022
jankeromnes
jankeromnes approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! 👋

I have no idea how to test this (also, the "how to test" instructions are empty) but I'm happy to rubber-stamp-approve the 2-lines removed from components/common-go/kubernetes/kubernetes.go (co-owned by team WebApp).

mads-hartmann
mads-hartmann reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks a lot for following up on this 🎉

@jenting
Copy link
Contributor

jenting commented Jun 14, 2022 •
edited

All comments addressed.

/unhold

@roboquat roboquat merged commit e1b335c into main Jun 14, 2022
@roboquat roboquat deleted the pavel/10590 branch June 14, 2022 11:36
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann left review comments

@csweichel csweichel csweichel approved these changes

@jankeromnes jankeromnes jankeromnes approved these changes

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tracing] fix workspace running trace
6 participants
@sagor999 @jenting @mads-hartmann @jankeromnes @csweichel @roboquat