-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git-ignore all files from the '.idea' folder, except gradle.xml #10599
Conversation
We committed .idea folder to import gradle modules on opening of IntelliJ. If we remove modules then we can rather delete entire .idea folder completely? |
I tried removing and git-ignoring the whole folder [1][2], but then we'd receive a lot of notifications when opening new workspaces. Also, the gateway-plugin and backend-plugin won't be detected as Gradle projects: |
Should we close it then? |
d4b7289
to
b44139e
Compare
I've updated the code with a different approach: Removed everything except the What do you think? I've also updated the Title and Description of the PR to reflect these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try if it does not cause any perf drawbacks
/hold
/cc @easyCZ as he has made changes to .idea folder previously and has been working with GoLand. |
@felladrin I don't think it is so relevant for GoLand. I was thinking can we put parent gradle project in root instead? and completely remove .idea? See https://docs.gradle.org/current/userguide/multi_project_builds.html#sec:creating_multi_project_builds Maybe IntelliJ will pick it up automatically then? |
Let me try it! |
3456dbc
to
b44139e
Compare
@akosyakov, I tried adding settings.gradle.kts with the following content to the root, but, although it worked via command line ( rootProject.name = "gitpod"
include("backend-plugin")
project(":backend-plugin").projectDir = file("components/ide/jetbrains/backend-plugin")
include("gateway-plugin")
project(":gateway-plugin").projectDir = file("components/ide/jetbrains/gateway-plugin") I've asked JetBrains Team if there's a specific way to do it, but meanwhile, I'd like to merge it with the current approach of leaving just ".idea/gradle.xml" file committed. |
@felladrin yes, go ahead with current approach |
/unhold |
Description
When opening Gitpod repository on different JetBrains IDEs cause the changes on files inside .idea folder. Currently we simply ignore those files by hand at the moment we're going to commit code changes.
But we actually don't need most of the files inside .idea folder. So this PR git-ignores all files from the '.idea' folder, except
gradle.xml
as it's required to initialize the Gradle projects from "backend-plugin" and "gateway-plugin" folders, allowing autocomplete to the Kotlin files and other integrations with the IDE.Related Issue(s)
NONE.
How to test
git status
) after the project finishes indexing.backend-plugin
andgateway-plugin
(both from insidecomponents/ide/jetbrains
) have Intellisense working properly.Release Notes
Documentation