Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadgen: fix the error handling when failed to get the ws infomation. #10618

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Jun 13, 2022

Description

Related Issue(s)

NONE

How to test

Run loadgen

Release Notes

NONE

Documentation

@utam0k utam0k requested a review from a team June 13, 2022 08:48
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 13, 2022
Comment on lines +209 to +212
} else {
if len(resp.GetStatus()) == 0 {
break
}
Copy link
Contributor

@jenting jenting Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It address the #9940 (comment)

@roboquat roboquat merged commit 85c66e3 into main Jun 13, 2022
@roboquat roboquat deleted the to/loadgen-fix branch June 13, 2022 09:08
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants