Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add probe metrics to preview environment #10634

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Add probe metrics to preview environment #10634

merged 1 commit into from
Jun 14, 2022

Conversation

ArthurSens
Copy link
Contributor

Signed-off-by: ArthurSens arthursens2005@gmail.com

Description

This is a follow up to gitpod-io/observability#140. It will add the prober and the configuration to monitor it with Prometheus to our preview-environments

Opening as a draft because the upstream PR needs to be merged first

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/2734

How to test

  • Run a job with werft run github -f -s .werft/observability/monitoring-satellite.ts -a withObservabilityBranch="as/prober"
  • Connect to the preview environment with previewctl install-context
  • Expose Prometheus UI with kubectl port-forward prometheus-k8s 9090
  • You should be able to query metrics like probe_success

Release Notes

NONE

Documentation

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🛹 Feel free to move out of draft when you're ready to have it merged.

@ArthurSens ArthurSens marked this pull request as ready for review June 14, 2022 09:30
@roboquat roboquat merged commit b59998f into main Jun 14, 2022
@roboquat roboquat deleted the as/probes branch June 14, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants