Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db-sync] Format test file + increase 2 test timeouts #10657

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

jankeromnes
Copy link
Contributor

Description

This increases the default test timeout 2s → 10s for these two slow 'Basic unidirectional replication' tests:

  • 'Should overwrite outdated values and keep newer ones intact'
  • 'Should pick up from the last replication time'

Related Issue(s)

Fixes flaky test failures like https://werft.gitpod-dev.com/job/gitpod-build-main.3560 :

  1) Basic unidirectional replication
       Should overwrite outdated values and keep newer ones intact:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

  2) Basic unidirectional replication
       Should pick up from the last replication time:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

How to test

  1. Should still build & pass all tests (hopefully without timeouts)

Release Notes

NONE

Documentation

@jankeromnes jankeromnes marked this pull request as ready for review June 14, 2022 13:09
@jankeromnes jankeromnes requested a review from a team June 14, 2022 13:09
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 14, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(semantic) diff looks good, unit tests + build is green: ✔️

Increases default test timeout 2s → 10s for these two slow 'Basic unidirectional replication' tests:
- 'Should overwrite outdated values and keep newer ones intact'
- 'Should pick up from the last replication time'
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jun 14, 2022

(semantic) diff looks good, unit tests + build is green: ✔️

Whoa, that was fast. Many thanks! 🚀

And apologies for the cross-fire (I found the change too hard to read, so I split the formatting and the semantic change into two commits -- but it should still be exactly the same change).

@geropl geropl self-assigned this Jun 14, 2022
@roboquat roboquat merged commit d1e04b7 into main Jun 14, 2022
@roboquat roboquat deleted the jx/fix-timeout branch June 14, 2022 13:21
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants