Preview environments: Add extra external_labels to Prometheus #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add extra external_labels for preview environments. External labels are labels that are added to all metrics when Prometheus performs remote-write to a Long Term Storage. More context on why we need them can be seen in the issue https://github.com/gitpod-io/ops/issues/2770
Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/2771
How to test
werft run github -f -s .werft/jobs/build/deploy-to-preview-environment.ts -s .werft/observability/monitoring-satellite.tspreviewctl install-contextkubectl describe prometheus k8sRelease Notes