Revert "Change disk bus from scsi to virtio to gain performance" #10735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9552b60.
|
I think this change caused preview envs to fail (well, the vm to fail to start) |
|
/werft run github -j .werft/build.yaml -a updateGitHubStatus=gitpod-io/gitpod -a no-preview=true 👍 started the job as gitpod-build-revert-10721-jenting-bus-from-scsi-to-virtio.1 |
🤔 I thought the change worked, but it seems to be no. |
jenting
approved these changes
Jun 17, 2022
|
I think what might have happened is that job protection tricked us again |
|
Absolutely yes 🤦🏻🤦🏻🤦🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9552b60.
Description
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation