Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previews: Remote-write metrics to core-dev #10737

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Jun 17, 2022

Signed-off-by: ArthurSens arthursens2005@gmail.com

Description

Configure Prometheus in Preview Environments to remote-write metrics to core-dev, but only the ones needed for our SLIs.

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/2764
Fixes https://github.com/gitpod-io/ops/issues/2766

How to test

Unfortunately, we're still having some network issues between previews and core-dev, but once that is solved we should be able to query metrics from the core-dev Prometheus with the following query:

{environment="preview-environment"}

Release Notes

NONE

Werft options:

  • /werft with-preview

Comment on lines 151 to 160
- name: PROM_REMOTE_WRITE_USER
valueFrom:
secretKeyRef:
name: prometheus-remote-write-auth
key: user
- name: PROM_REMOTE_WRITE_USER
valueFrom:
secretKeyRef:
name: prometheus-remote-write-auth
key: password
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liam-j-bennett just to let you know, the auth problem is that I'm repeating PROM_REMOTE_WRITE_USER here 🤦

One of those should be PROM_REMOTE_WRITE_PASSWORD, I'm fixing and then it should be good to merge

urls: ['https://prometheus.gitpod-dev.com/api/v1/write'],
writeRelabelConfigs: [{
sourceLabels: ['__name__'],
regex: 'probe_.*|rest_client_requests_total',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed that this regex drops the up metric, which is required by SLI 2.

The up metric is built from ALL targets, so I need to figure out a good regex that will only give us the up from probers...

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-as-preview-remote-write.9 because the annotations in the pull request description changed
(with .werft/ from main)

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Jun 22, 2022

@ArthurSens Is this ready for review? I wasn't sure if the network problems were resolved ☺️

@ArthurSens
Copy link
Contributor Author

Yes, they've been resolved :)

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛹

@roboquat roboquat merged commit 89b102c into main Jun 22, 2022
@roboquat roboquat deleted the as/preview-remote-write branch June 22, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants