Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[werft] Delete unused file .werft/jobs/build/helm/values.payment.yaml #10761

Merged
merged 1 commit into from
Jun 20, 2022
Merged

[werft] Delete unused file .werft/jobs/build/helm/values.payment.yaml #10761

merged 1 commit into from
Jun 20, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Jun 20, 2022 •
edited

Description

From #10660 (comment):

Indeed, this is a left-over - and we have been cargo-culting here 馃檲 Let's remove (incl. all references)! 馃憤

I saw no direct references.

Related Issue(s)

Fixes #

How to test

  1. Should still build, even with payment

Release Notes

NONE

Documentation

  • /werft with-payment

@jankeromnes jankeromnes mentioned this pull request Jun 20, 2022
Merged
1 task
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jun 20, 2022 •
edited by werft-gitpod-dev-com bot

Works without payment. Now let's test with payment.

/werft run

馃憤 started the job as gitpod-build-jx-delete-unused.1
(with .werft/ from main)

andrew-farries
andrew-farries approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@jankeromnes
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 464de86 into main Jun 20, 2022
@roboquat roboquat deleted the jx/delete-unused branch June 20, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jankeromnes @andrew-farries @roboquat