Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db][protocol] Implement a CostCenter entity to attribute workspace usage to #10788

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Implement a CostCenter entity to attribute workspace usage to.

Related Issue(s)

Fixes #10757

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jun 21, 2022

@geropl Apologies for rushing into this 🙈 I actually implemented all this before I saw your request for further alignment, which I agree with: #10757 (comment)

So, I'm happy to further align on this concept and on naming, then reflect any changes back in this PR. 👍

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Jun 29, 2022

Whoops, looks like this suffered from bit-rot a bit.

If anyone would like to pick this up, please feel free to force-push to this branch, or salvage anything that looks useful from it (no need to attribute me 😊).

@stale
Copy link

stale bot commented Jul 10, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 10, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jul 18, 2022
@roboquat roboquat added size/XS and removed size/L labels Jul 20, 2022
@AlexTugarev AlexTugarev reopened this Jul 20, 2022
@roboquat roboquat added size/L and removed size/XS labels Jul 20, 2022
@AlexTugarev AlexTugarev marked this pull request as ready for review July 20, 2022 06:54
@AlexTugarev AlexTugarev requested a review from a team July 20, 2022 06:54
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 20, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concise and spot-on - nice! 🧡

@roboquat roboquat merged commit 7057101 into main Jul 20, 2022
@roboquat roboquat deleted the jx/cost-center branch July 20, 2022 07:05
@easyCZ
Copy link
Member

easyCZ commented Jul 20, 2022

How is no-spending limit represented here?
What will populate this table?

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Usage-based] Implement a "Cost Center" entity
5 participants