Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder] Improve 'registry not allowed' log message #10793

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Jun 21, 2022

Description

We stumble upon this problem quite often when in self-hosted setups the registry has not been added to the allowlist. Therefore, a higher log level and a hint to the config would be valuable.

How to test

It's just a change in the log message. Have a look and decide whether you like it or not. Nothing more to test.

Release Notes

NONE

We stumble upon this problem quite often when in self-hosted setups the registry has not been added to the allowlist. Therefore, a higher log level and a hint to the config would be valuable.
@sagor999
Copy link
Contributor

Rebased to fix build error.

@roboquat roboquat merged commit 1617d3d into main Jun 21, 2022
@roboquat roboquat deleted the clu/reg-not-allows-msg branch June 21, 2022 20:05
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants