[ws-manager] Watch VolumeSnapshot object and notify to the Pod finalizer loop #10820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add volume_snapshot_controller to watch the VolumeSnapshot object. Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
|
started the job as gitpod-build-jenting-ws-manager-volume-snapshot-10334.7 because the annotations in the pull request description changed |
jenting
force-pushed
the
jenting/ws-manager-volume-snapshot-10334
branch
from
90f7034
to
038827c
Compare
sagor999
reviewed
Jun 22, 2022
When the VolumeSnapshot object is ready, notify to the Pod that it belongs to. Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
jenting
force-pushed
the
jenting/ws-manager-volume-snapshot-10334
branch
from
038827c
to
38f3cf7
Compare
Added, PTAL 🙏 |
|
/unhold tested, works like a charm! |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add volume_snapshot_controller to watch the VolumeSnapshot object, and once the VolumeSnapshot object is ready, notify the Pod in the finalizer loop that the VolumeSnapshot is ready.
This improves the volume snapshot metric
gitpod_ws_manager_volume_snapshot_secondsmore accurately when the workspace stops.Related Issue(s)
Fixes #10334
How to test
kubectl get vs -wkubectl port-forward <ws-manager-pod> 9500:9500curl -XGET 'localhost:9500/metrics' | grep gitpod_ws_manager_volume_snapshot_seconds, and check if the time matches step 2.Release Notes
Documentation
None
Werft options: