Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger to bootstrap a preview environment in workspace integration test job #10846

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Trigger to bootstrap a preview environment in workspace integration test job #10846

merged 1 commit into from
Jun 23, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 23, 2022 •
edited

Description

Trigger to bootstrap a preview environment in workspace integration test job.

Related Issue(s)

Fixes #

How to test

werft run github -j .werft/workspace-run-integration-tests.yaml

Release Notes

None

Documentation

None

Werft options:

  • /werft with-preview

@jenting
Trigger to bootstrap a preview environment in workspace integration t…
ea29f74 
…est job

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/wk-inte-test-job-with-preview-annotation branch from a40eba2 to ea29f74 Compare June 23, 2022 01:40
@jenting jenting marked this pull request as ready for review June 23, 2022 01:54
@jenting jenting requested a review from a team June 23, 2022 01:54
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 23, 2022
@utam0k
Copy link
Contributor

utam0k commented Jun 23, 2022

I have a question. Why do we don't use the main branch for the integration tests?

@jenting jenting marked this pull request as draft June 23, 2022 04:58
@jenting jenting marked this pull request as ready for review June 23, 2022 05:05
@roboquat roboquat merged commit 96cc345 into main Jun 23, 2022
@roboquat roboquat deleted the jenting/wk-inte-test-job-with-preview-annotation branch June 23, 2022 13:38
@jenting
Copy link
Contributor Author

jenting commented Jun 24, 2022

I have a question. Why do we don't use the main branch for the integration tests?

Yes, we could. But since the main branch did not have a corresponding preview environment, we need to call werft run github -a with-preview=true on the main branch. It will bring up a preview environment with the main branch.
But probably other teams will have a job/test on this main preview environment.

Or we could have a dedicated preview environment for the workspace integration test job but with some enhancement. We could create a new branch from the main branch without adding any new commit on this new branch and then push the branch to remote and run werft run github -a with-preview=true to bootstrap the preview environment.

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jenting @utam0k @aledbf @roboquat