Clean up unused attributedTeamId column from workspace instances post-deployment
#10876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not merge this before #10868 is successfully deployed to production. /hold |
jankeromnes
force-pushed
the
jx/attribution-id
branch
from
d5a0667
to
0678bd6
Compare
jankeromnes
force-pushed
the
jx/attribution-id-2
branch
from
439b1b6
to
a7c8854
Compare
jankeromnes
force-pushed
the
jx/attribution-id
branch
from
0678bd6
to
303f5aa
Compare
jankeromnes
force-pushed
the
jx/attribution-id-2
branch
from
a7c8854
to
105796d
Compare
jankeromnes
force-pushed
the
jx/attribution-id
branch
from
303f5aa
to
b3c03b9
Compare
jankeromnes
force-pushed
the
jx/attribution-id-2
branch
from
105796d
to
fd85f28
Compare
jankeromnes
force-pushed
the
jx/attribution-id-2
branch
from
fd85f28
to
7e23a21
Compare
jankeromnes
force-pushed
the
jx/attribution-id-2
branch
from
7e23a21
to
fa1f832
Compare
|
New column got merged and deployed, so we can clean up now. 🧹 /unhold |
|
LGTM, I guess in self-hosted, when it runs migrations it will first add it and then remove it later on but that should be okay. |
easyCZ
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once we've merged and successfully deployed #10868, we should merge this Pull Request to clean up the left-over
attributedTeamIdcolumn.Optionally, we may also want to "save" the historical attribution data from that older column and back-fill the newer column with it.
Related Issue(s)
Follow-up to #10868
How to test
Release Notes
Documentation
Werft options: