Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up after an error happens #10884

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Clean up after an error happens #10884

merged 1 commit into from
Jun 23, 2022

Conversation

meysholdt
Copy link
Member

Description

Follow-up fix for #10877: Clean up after an error. Without this cleanup, subsequent connection attempts will fail.

Related Issue(s)

Fixes #10877

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@meysholdt meysholdt requested a review from a team June 23, 2022 19:32
@meysholdt
Copy link
Member Author

Example error:

af-add-tim687a7319a0 (default) - Checking status of the MySQL pod
STDERR: error: You must be logged in to the server (Unauthorized)

STDERR: error: You must be logged in to the server (Unauthorized)

af-add-tim687a7319a0 (default) - is-active=true - The database is not reachable, assuming env is not active

@meysholdt
Copy link
Member Author

Example for a succesful dry run.

@roboquat roboquat merged commit 2dd8d4d into main Jun 23, 2022
@roboquat roboquat deleted the me/fix branch June 23, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
release-note-none size/XS team: devx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meysholdt @ArthurSens @roboquat