Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager] Add volume snapshot events to workspace pod event #10889

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Jun 24, 2022

Description

It would be great if we could add events to the workspace pod that shows the progress of volume snapshot operations, we could see the event by kubectl describe pods <workspace-pod-name>.
That way it will be easier to debug later on if the workspace pod is stuck or misbehaving.

image

Related Issue(s)

Fixes #10887

How to test

  1. Create a preview environment and enable the feature flag persistent_volume_claim.
  2. Launch a workspace and write a large data into it.
    dd if=/dev/urandom of=data bs=16M count=256
  3. Stop the workspace.
  4. During the workspace stopping, kubectl describe the workspace pod to see the volume snapshot event.
    kubectl describe pod -l component=workspace

Release Notes

[experimental] Add volume snapshot events to workspace pod event

Documentation

None

Werft options:

  • /werft with-preview

@jenting jenting requested a review from a team June 24, 2022 06:30
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jun 24, 2022
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting force-pushed the jenting/add-volume-snapshot-related-10887 branch from 28cc322 to 1e704f6 Compare June 24, 2022 06:31
@jenting jenting changed the title Add volume snapshot events to workspace pod event [ws-manager] Add volume snapshot events to workspace pod event Jun 24, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-add-volume-snapshot-related-10887.4 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat merged commit 3e7c250 into main Jun 24, 2022
@roboquat roboquat deleted the jenting/add-volume-snapshot-related-10887 branch June 24, 2022 15:59
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ws-manager: Add volume snapshot related events to workspace pod event log
3 participants