-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Usage-based] When payment is enabled, attribute all workspace instance usage to an explicitly selected "billing account" #10893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
jx/billing-attribution
branch
4 times, most recently
from
June 24, 2022 12:48
f6b577c
to
fa4ad76
Compare
jankeromnes
changed the title
[Usage-based] When payment is enabled, attribute workspace instance usage based on new billing model
[Usage-based] When payment is enabled, attribute all workspace instance usage to an expicitly selected "billing account"
Jun 24, 2022
jankeromnes
changed the title
[Usage-based] When payment is enabled, attribute all workspace instance usage to an expicitly selected "billing account"
[Usage-based] When payment is enabled, attribute all workspace instance usage to an explicitly selected "billing account"
Jun 24, 2022
geropl
reviewed
Jun 24, 2022
geropl
reviewed
Jun 24, 2022
</Link>{" "} | ||
to set up usage-based billing. | ||
</p> | ||
<div className="mt-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
geropl
reviewed
Jun 24, 2022
This was referenced Jun 27, 2022
easyCZ
force-pushed
the
jx/billing-attribution
branch
from
June 27, 2022 09:19
fa4ad76
to
1320d58
Compare
geropl
reviewed
Jun 27, 2022
…it to implement 'billing-based attribution'
…fy a 'billing account' to attribute all their usage to
jankeromnes
force-pushed
the
jx/billing-attribution
branch
from
June 27, 2022 14:00
1320d58
to
898d9ed
Compare
geropl
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
release-note-none
size/L
team: webapp
Issue belongs to the WebApp team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When payment is enabled, attribute all workspace instance usage to an explicitly selected "billing account".
TODO:
usageAttributionId
of a workspace instance, attribute based on the workspace owner's selected "billing account"Follow-ups:
usageAttributionId
where it makes sense)Related Issue(s)
Fixes #10901
How to test
a. Workspace with no project --> your user
b. Workspace with user project --> your user
c. Workspace with Team A project --> your user
d. Workspace with Team B project --> your user
a. Workspace with no project --> team A
b. Workspace with user project --> team A
c. Workspace with Team A project --> team A
d. Workspace with Team B project --> team A
*To verify attribution, open this PR in Gitpod, then run:
Example output:
You can also verify every user's
usageAttributionId
preference like so:Release Notes
Documentation
Werft options: