[server] Return raw duration from getWorkspaceTimeout
#10896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the raw duration from getWorkspaceTimeout, ie in the format '60m' before translation to 'short' or 'extended' etc.
|
/werft run with-preview 👍 started the job as gitpod-build-af-return-raw-duration-from-getworkspace-time.2 |
3 tasks
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
rawDurationfield to the object returned bygetWorkspaceTimeout. This represents the workspace timeout as a string in the format30m,60m,180m. The existingdurationfield translates these times intoshortorextended.This is necessary for the new
gp timeout showcommand (#10782) to present the workspace timeout in a format that makes the most sense to the user.Related Issue(s)
#10782
How to test
Observe the new
rawDurationfield in the response object:{ "duration": "short", "durationRaw": "30m" "canChange": true, }Release Notes
Documentation
None
Werft options