Disable 5 second delay before returning feature flag value #10897
Conversation
…lag value Co-authored-by: Milan Pavlik <milan@gitpod.io>
jankeromnes
force-pushed
the
jx/fast-config-flag
branch
from
227ea87
to
faf1eba
Compare
| @@ -35,6 +36,7 @@ export function newNonProductionConfigCatClient(): Client { | |||
| // clientKey is an identifier of our ConfigCat application. It is not a secret. | |||
| const clientKey = "WBLaCPtkjkqKHlHedziE9g/LEAOCNkbuUKiqUZAcVg7dw"; | |||
| const client = configcat.createClient(clientKey, { | |||
| maxInitWaitTimeSeconds: 0, | |||
There was a problem hiding this comment.
What's the purpose of the default wait time of 5 seconds? Any downsides to setting it to 0?
There was a problem hiding this comment.
I'm also surprised 5 secs was the default value, but my guess is that it's to ensure it doesn't slow down load of other assets.
In some use-cases, they instantiate the client inside index.ts and use afterwards.
There was a problem hiding this comment.
I don't know, but agree with @easyCZ's theory. 👍
Unfortunately, there seems to be no documentation for this feature apart from the one-line description shown in my PR description (see also ConfigCat's source code)
Digging a bit into ConfigCat's history, it looks like this feature was already part of this initial commit, which unfortunately doesn't provide much context as to why this feature is useful. 🙈
|
/unhold |
roboquat
added
deployed: webapp
Description
While debugging with @easyCZ why getting feature flag values was sometimes so slow, we found that by default, our experiments client waits for 5 seconds before returning the initial value (see all options):
Disabling this delay makes getting feature flag values instantaneous. 🪄 ⚡
Related Issue(s)
Fixes #10786
How to test
Release Notes
Documentation
Werft options: