Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: implementation customization functions #10906

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Jun 24, 2022

Description

Implementation of the customization functions as per the agreed spec. Also contains plenty of unit tests to ensure that the spec is applied correctly

Related Issue(s)

Fixes #10826
Fixes #10902
Fixes #10903

How to test

Enter a customization parameter in the config.yaml as per the documentation and check it generates the appropriate output

NB the example in the docs gives ws-manager deployment as an example of overriding things. This was missed out of the original PR and a separate PR has been raised to add that in - please use something else instead of ws-manager for testing

Release Notes

[installer]: implementation customization functions

Documentation

Werft options:

  • /werft with-preview

@mrsimonemms mrsimonemms marked this pull request as ready for review June 24, 2022 15:18
@mrsimonemms mrsimonemms requested a review from a team June 24, 2022 15:18
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Jun 24, 2022
@mrsimonemms mrsimonemms marked this pull request as draft June 24, 2022 16:18
@mrsimonemms mrsimonemms marked this pull request as ready for review June 24, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for custom labels (stretch goal) Allow for custom envvars Allow for custom annotations
3 participants