Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jb] add track for sent closed heartbeat #10978

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[jb] add track for sent closed heartbeat #10978

merged 1 commit into from
Jun 29, 2022

Conversation

akosyakov
Copy link
Member

Description

add track for sent closed heartbeat

Related Issue(s)

Fixes #

How to test

  1. start a workspace with IntelliJ
  2. open and the close the client
  3. monitor in segment, it should send a ide_close_signal event

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@akosyakov akosyakov requested a review from a team June 28, 2022 13:50
@iQQBot
Copy link
Contributor

iQQBot commented Jun 28, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-ak-jb-close-signal.1
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Jun 28, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-ak-jb-close-signal.2
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Jun 28, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-ak-jb-close-signal.3
(with .werft/ from main)

@iQQBot
Copy link
Contributor

iQQBot commented Jun 28, 2022

manual patch node add label gitpod.io/workload_services: "true"

@akosyakov
Copy link
Member Author

@iQQBot Could you have a look please? It worked for me now:
Screenshot 2022-06-29 at 08 33 59

iQQBot
iQQBot approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
works for me too

@roboquat roboquat merged commit a26a9bc into main Jun 29, 2022
@roboquat roboquat deleted the ak/jb_close_signal branch June 29, 2022 06:41
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

@mustard-mh mustard-mh Awaiting requested review from mustard-mh

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/M team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akosyakov @iQQBot @roboquat