Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preview VM image #10987

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update preview VM image #10987

merged 1 commit into from
Jun 28, 2022

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Jun 28, 2022

Signed-off-by: ArthurSens arthursens2005@gmail.com

Description

Updates VM image to this one

Related Issue(s)

Fixes #10832

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-as-update-vm-image.1 because the annotations in the pull request description changed
(with .werft/ from main)

@ArthurSens
Copy link
Contributor Author

I believe we need to run this and while making sure the preview runs with the updated image?

@ArthurSens
Copy link
Contributor Author

From a workspace inside the preview:

image

Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM and the preview env runs as well.

@roboquat roboquat merged commit 7bc43de into main Jun 28, 2022
@roboquat roboquat deleted the as/update-vm-image branch June 28, 2022 19:15
@meysholdt
Copy link
Member

The file @kylos101 asked us to test for exists, but in a different location. Not sure if this makes a difference.

# ls /sys/fs/cgroup/unified/cgroup.controllers 
/sys/fs/cgroup/unified/cgroup.controllers

The cgroup2 fs clearly is mounted:

# mount -l | grep cgroup2
cgroup2 on /sys/fs/cgroup/unified type cgroup2 (rw,nosuid,nodev,noexec,relatime)

@meysholdt
Copy link
Member

CC @Furisto

@kylos101 kylos101 mentioned this pull request Jun 28, 2022
1 task
@Furisto
Copy link
Member

Furisto commented Jun 28, 2022

That does not look right. The cgroup filesystem should be mounted at /sys/fs/cgroup. If it is mounted at /sys/fs/cgroup/unified then it points to a hybrid configuration (which in practice is basically cgroup v1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[preview envirionments] run with cgroup v2
4 participants