Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Expose metrics for reconciles started and duration #10996

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[usage] Expose metrics for reconciles started and duration #10996

merged 1 commit into from
Jun 29, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jun 29, 2022 •
edited

Description

So that we can setup dashboards and alerts on these

Related Issue(s)

Fixes #

How to test

  1. Get preview context
  2. kubectl port-forward deployment/usage 9500:9500
  3. curl http://localhost:9500/metrics | grep gitpod and observe the metrics defined in this PR show up

Release Notes

NONE

Documentation

NONE

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team June 29, 2022 08:23
@easyCZ
Copy link
Member Author

easyCZ commented Jun 29, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-mp-usage-tick-metrics.1
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 29, 2022
@jankeromnes jankeromnes self-assigned this Jun 29, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Jun 29, 2022 •
edited by werft-gitpod-dev-com bot

Thanks for the helpful test instructions! Taking a look 👀

jankeromnes
jankeromnes approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks! This works as advertised. ✨

Screenshot 2022-06-29 at 12 39 49

I can't comment on whether the code change is the best approach, as I don't have any experience with Go component metrics reporting best practices, but other than that this looks good to me. 👍

@roboquat roboquat merged commit b5afbce into main Jun 29, 2022
@roboquat roboquat deleted the mp/usage-tick-metrics branch June 29, 2022 10:42
@easyCZ easyCZ mentioned this pull request Jun 29, 2022
Closed
73 tasks
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees

@jankeromnes jankeromnes

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@easyCZ @jankeromnes @roboquat