Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Add WorkspaceClass field to WorkspaceInstance model (in go) #11004

Merged
merged 1 commit into from
Jun 30, 2022
Merged

[usage] Add WorkspaceClass field to WorkspaceInstance model (in go) #11004

merged 1 commit into from
Jun 30, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jun 29, 2022 •
edited

Description

Originally implemented in TS in #10454

Adds the field definition into the Go model, such that it can be used for computing usage by WorkspaceClass

Related Issue(s)

How to test

Unit tests work

Release Notes

NONE

Documentation

NONE

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team June 29, 2022 12:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 29, 2022
geropl
geropl approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat merged commit 70150e2 into main Jun 30, 2022
@roboquat roboquat deleted the mp/usage-workspace-class-field branch June 30, 2022 11:49
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@easyCZ @geropl @roboquat