Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the Requests Memory from Workspace Resources to increase memory available for Java #11012

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

felladrin
Copy link
Contributor

@felladrin felladrin commented Jun 29, 2022

Description

Currently, when we create a workspace from https://github.com/gitpod-io/spring-petclinic on Preview Environment, it will trigger an OutOfMemoryError during the Build Task.

image

This happens because JAVA_TOOL_OPTIONS currently is set to -Xmx134m due to this line which affects GITPOD_MEMORY env var, which in turn is used to set Java's memory here.

This PR increases Preview Environments memory to address this issue. By increasing memory to 256Mi, JAVA_TOOL_OPTIONS becomes -Xmx268m, which is enough to make "gitpod-io/spring-petclinic" to build correctly:

image

image

Related Issue(s)

None.

How to test

Release Notes

NONE

Documentation

None.

Werft options:

  • /werft with-preview

@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Jun 29, 2022
@felladrin felladrin marked this pull request as ready for review June 29, 2022 16:32
@felladrin felladrin changed the title Increase Preview Environments memory Double the Requests Memory from Workspace Resources to increase memory available for Java Jun 29, 2022
@akosyakov akosyakov requested review from mads-hartmann, vulkoingim and meysholdt and removed request for mads-hartmann June 30, 2022 06:57
@roboquat roboquat merged commit ad3776e into main Jun 30, 2022
@roboquat roboquat deleted the felladrin/increase-preview-env-memory branch June 30, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants