Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up oauth logging #11066

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Clean up oauth logging #11066

merged 2 commits into from
Jul 1, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jul 1, 2022 •
edited

Description

Remove sensitive data from server logs.

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/3062

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@andrew-farries andrew-farries force-pushed the af/oauth-logging branch 2 times, most recently from 6a2adf2 to cdc4ce0 Compare July 1, 2022 07:28
@roboquat roboquat added size/S and removed size/XS labels Jul 1, 2022
@geropl
Copy link
Member

geropl commented Jul 1, 2022

@andrew-farries The PR LGTM! 🙃

@andrew-farries andrew-farries changed the title oauth logging Clean up oauth logging Jul 1, 2022
@andrew-farries andrew-farries marked this pull request as ready for review July 1, 2022 08:51
@andrew-farries andrew-farries requested a review from a team July 1, 2022 08:51
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 1, 2022
geropl
geropl approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log is clean, thank you! 💪

@roboquat roboquat merged commit 2d71cd0 into main Jul 1, 2022
@roboquat roboquat deleted the af/oauth-logging branch July 1, 2022 08:59
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrew-farries @geropl @roboquat