improve seccomp notify #11082
Merged
improve seccomp notify #11082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
reviewed
Jul 1, 2022
| ec := make(chan error) | ||
| stp := make(chan struct{}) | ||
|
|
||
| handledSyscalls := mapHandler(handler) | ||
| go func() { | ||
| for { | ||
| req, err := libseccomp.NotifReceive(fd) | ||
| if err != nil { | ||
| if err == syscall.ENOENT { | ||
| log.WithError(err).Warn("failed to get notification beucase it has already been not valid anymore(the kernel sets that)") |
There was a problem hiding this comment.
What's the purpose of the warning?
There was a problem hiding this comment.
The cause may be a query due to this error. This is to track them down.
Incidentally, libseccomp-golang also handles the error separately.
https://github.com/seccomp/libseccomp-golang/blob/c0b6cd81f16769ee69fb39d55016b98f7b232021/seccomp_internal.go#L812-L814
aledbf
approved these changes
Jul 5, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #9247
Precisely up to the reduction. For some reason seccomp notify is cancelled by the linux kernel. Neither docker-compose nor runc can handle it.
We mitigate it a bit by processing it as quickly as possible.
More detail
seccomp/libseccomp-golang@3879420
How to test
open this repository and works fine
https://github.com/appwrite/integration-for-gitpod
Release Notes
Documentation
Werft options: