Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prebuild status description alignment #11086

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Update prebuild status description alignment #11086

merged 1 commit into from
Jul 1, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 1, 2022

Description

Following up from #10696, this will fix text alignment for the prebuild status description text.

Cc @geropl based on a recent discussion (internal).

How to test

Screenshots

BEFORE AFTER
logs-before logs-after

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@gtsiolis gtsiolis requested a review from a team July 1, 2022 14:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 1, 2022
geropl
geropl approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for caring @gtsiolis ! 🙏

@roboquat roboquat merged commit 1f5a0ed into main Jul 1, 2022
@roboquat roboquat deleted the gt/update-prebuild-status-description-alignment branch July 1, 2022 14:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gtsiolis @geropl @roboquat