Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[usage] Workspace Pricer uses config #11109

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[usage] Workspace Pricer uses config #11109

merged 1 commit into from
Jul 13, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 4, 2022 •
edited

Description

Provide config to usage component about how to price each workspace class

Related Issue(s)

Fixes #

How to test

  1. Run the build directly, as it changes werft config werft run github -j .werft/build.yaml -f
  2. Check the pod started
  3. Check pod logs and validate you're seeing
{"config":{"controllerSchedule":"1h0m0s","creditsPerMinuteByWorkspaceClass":{"default":0.1666666667,"gitpodio-internal-xl":0.3333333333},"server":{"services":{"grpc":{"address":":9001"}}}},"level":"info","message":"Starting usage component.","serviceContext":{"service":"usage","version":"commit-5201aba69e22b07e3d75e0181e19f7711ed987e3"},"severity":"INFO","time":"2022-07-11T08:53:29Z"}

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ changed the base branch from main to mp/usage-config-file July 4, 2022 10:12
@roboquat roboquat added the size/S label Jul 4, 2022
@easyCZ easyCZ changed the title [usage] Use a config file to configure usage component [usage] Workspace Pricer uses config Jul 4, 2022
@roboquat roboquat added size/M and removed size/S labels Jul 4, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jul 4, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-mp-usage-configure-classes.3
(with .werft/ from main)

@easyCZ easyCZ mentioned this pull request Jul 4, 2022
Closed
1 task
@easyCZ
Copy link
Member Author

easyCZ commented Jul 4, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview

👍 started the job as gitpod-build-mp-usage-configure-classes.5
(with .werft/ from main)

Base automatically changed from mp/usage-config-file to main July 4, 2022 15:14
@roboquat roboquat added size/XL and removed size/M labels Jul 4, 2022
@easyCZ easyCZ force-pushed the mp/usage-configure-classes branch from 87e4d3c to 438ba84 Compare July 11, 2022 08:06
@roboquat roboquat added size/M and removed size/XL labels Jul 11, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jul 11, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview with-payment

👍 started the job as gitpod-build-mp-usage-configure-classes.7
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/usage-configure-classes branch from 438ba84 to ea6e46b Compare July 11, 2022 08:24
@easyCZ easyCZ force-pushed the mp/usage-configure-classes branch from ea6e46b to 5201aba Compare July 11, 2022 08:26
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-usage-configure-classes.10 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ
Copy link
Member Author

easyCZ commented Jul 11, 2022 •
edited by werft-gitpod-dev-com bot

/werft run with-preview with-billing

👍 started the job as gitpod-build-mp-usage-configure-classes.11
(with .werft/ from main)

@easyCZ easyCZ marked this pull request as ready for review July 11, 2022 08:55
@easyCZ easyCZ requested review from a team July 11, 2022 08:55
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team labels Jul 11, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jul 11, 2022 •
edited by werft-gitpod-dev-com bot

/werft run

👍 started the job as gitpod-build-mp-usage-configure-classes.12
(with .werft/ from main)

andrew-farries
andrew-farries approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold just in case of the question about workspace class names.

components/usage/config.json
@@ -1,5 +1,9 @@
{
"controllerSchedule": "1h",
"creditsPerMinuteByWorkspaceClass": {
"default": 0.1666666667,
"gitpodio-internal-xl": 0.3333333333
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the final name for the workspace class? I think it was agreed that the workspace classes will be called standard and large.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are only human names, but the identifier is what's listed here

@andrew-farries andrew-farries self-assigned this Jul 12, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Jul 12, 2022

/unhold

Pothulapati
Pothulapati approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@roboquat roboquat merged commit 48411d7 into main Jul 13, 2022
@roboquat roboquat deleted the mp/usage-configure-classes branch July 13, 2022 06:50
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Pothulapati approved these changes

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees

@andrew-farries andrew-farries

Labels
deployed: webapp Meta team change is running in production release-note-none size/M team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@easyCZ @Pothulapati @andrew-farries @roboquat