Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration-test]fixes vscode integration test #11118

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Jul 4, 2022

Description

This PR fix IDE integration test (vscode only), for Jetbrains it needs refractory

Related Issue(s)

Fixes #

How to test

  1. start a workspace from this branch
  2. run werft run github -j .werft/ide-integration-tests-startup-vscode.yaml
  3. see build log, it will start a preview environment, and run vscode test case
  4. it will failed because vscode test failed, but it's not about this PR cc: @jeanp413

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

trap cleanup SIGINT SIGTERM EXIT

BUILD_ID=$(werft job list repo.ref==refs/heads/${BRANCH} -o yaml | yq r - "result[0].name")
BUILD_ID=$(werft job list repo.ref==refs/heads/${BRANCH} -o yaml | yq4 '.result[] | select(.metadata.annotations[].key == "with-preview") | .name' | head -1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to find exactly the build that has annotation with-preview

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job started, and vscode test failed [1] as expected.

Current branch compare to main branch

image

@roboquat roboquat merged commit d50859a into main Jul 5, 2022
@roboquat roboquat deleted the pd/fix-inte-test branch July 5, 2022 07:26
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/L team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants