[prebuild] Fix view when coming from prefix #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-laushinka-prebuild-11079.2 because the annotations in the pull request description changed |
roboquat
added
size/S
release-note-none
size/M
and removed
do-not-merge/release-note-label-needed
size/S
labels
laushinka
force-pushed
the
laushinka/prebuild-11079
branch
3 times, most recently
from
f53d25e
to
899c887
Compare
geropl
reviewed
Jul 4, 2022
geropl
reviewed
Jul 4, 2022
geropl
reviewed
Jul 4, 2022
laushinka
force-pushed
the
laushinka/prebuild-11079
branch
from
899c887
to
6df428a
Compare
laushinka
commented
Jul 4, 2022
| @@ -123,17 +123,19 @@ export default function PrebuildLogs(props: PrebuildLogsProps) { | |||
| }, [logsEmitter, props.workspaceId, workspaceInstance?.id, workspaceInstance?.status.phase]); | |||
|
|
|||
| return ( | |||
| <div className="rounded-xl overflow-hidden bg-gray-100 dark:bg-gray-800 flex flex-col"> | |||
| <div className="rounded-xl overflow-hidden bg-gray-100 dark:bg-gray-800 flex flex-col mb-8"> | |||
There was a problem hiding this comment.
Ended up adding the margin here - tested all three views. Also I think moving forward we should make the logs be centered in the screen. It's too off down there at the bottom.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the broken layout, but doesn't add yet the "Skip Prebuild" button as we intended in a recent epic. Skipping prebuilds will be covered in a follow-up issue.
Related Issue(s)
Fixes #11079
How to test
https://laushinka-be81110388.preview.gitpod-dev.com/#prebuild/[YOUR_REPO]Release Notes
Documentation
Werft options: