Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-proxy] Refactor SSH heartbeat GRPC connection #11130

Merged
merged 1 commit into from
Jul 5, 2022
Merged

[ws-proxy] Refactor SSH heartbeat GRPC connection #11130

merged 1 commit into from
Jul 5, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 5, 2022

Description

Refactor GRPC client connection

Related Issue(s)

Fixes #11020

Release Notes

NONE

Werft options:

  • /werft with-preview

@aledbf aledbf requested a review from a team July 5, 2022 01:41
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Jul 5, 2022
@roboquat roboquat merged commit 3353f39 into main Jul 5, 2022
@roboquat roboquat deleted the aledbf/wspc branch July 5, 2022 02:04
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ws-manager] potential go routines leak
3 participants
@aledbf @jenting @roboquat