Revert "Update k8s dependencies to v0.24.2" #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenting
requested review from
csweichel,
geropl,
aledbf,
sagor999 and
Furisto
as code owners
github-actions
bot
added
team: IDE
team: devx
team: delivery
github-actions
bot
added
team: devx
team: delivery
|
started the job as gitpod-build-revert-11003-aledbf-k8.1 because the annotations in the pull request description changed |
mads-hartmann
approved these changes
Jul 5, 2022
iQQBot
reviewed
Jul 5, 2022
I tried to revert 1 commit, but it caused a lot of conflicts because the |
mrsimonemms
approved these changes
Jul 5, 2022
iQQBot
approved these changes
Jul 5, 2022
|
We can choose to remove all status items at the end of the yaml generation |
Yes, we discussed in the incident channel, and we would like the installer to remove the status items rather than we ask the user to manually remove the status field. |
|
Preview environment works, removing the hold |
|
/unhold |
Furisto
approved these changes
Jul 5, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #11003
Bumping the k8s dependencies to v0.24.2, when the installer installs gitpod, it failed at
error validating data: ValidationError(NetworkPolicy): unknown field "status" in io.k8s.api.networking.v1.NetworkPolicyThe root cause is that the NetworkPolicy status introduces from v1.24 (
kubectl explain networkpolicy). However, our environment is still running v1.23.Instead of asking the user manually remove the
statusfield as we did before for StatefulSet status, it'd be good for the installer to auto remove thestatusfield.Release Notes
Werft options: