Align access level of Workspaces of type "prebuild" with Prebuilds #11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laushinka
reviewed
Jul 5, 2022
| resourceKind: "workspace", | ||
| workspaceType: "prebuild", | ||
| isOwner: false, | ||
| teamRole: undefined, |
There was a problem hiding this comment.
What is this case where the user is not the owner but also doesn't have a team?
There was a problem hiding this comment.
They have read access to the repository (repositoryAccess, see one line 👇 ).
That's the qualifier based on which we share access to prebuilds, and thus should be the same for workspaces (at least for those of type prebuild). 👍
This fixes the UI issue we see currently.
laushinka
approved these changes
Jul 5, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align access level of Workspaces of type "prebuild" with Prebuilds
ℹ️ It make sense to review this PR per commit:
Related Issue(s)
Fixes #11127
How to test
cd components/serveryarn testRelease Notes
Documentation
Werft options: