Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] PrebuildLogs: Always show button if there is one #11150

Merged
merged 3 commits into from
Jul 6, 2022
Merged

[dashboard] PrebuildLogs: Always show button if there is one #11150

merged 3 commits into from
Jul 6, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 5, 2022 •
edited

Description

This PR ensures that no matter the errors we hit, we always show an escape hatch (note the missing prebuild details bc that part failed, but we still see the "Skip Prebuild" button):

(also, it fixes yet another permission level bug. see this commit)
image

Related Issue(s)

Fixes #11148

How to test

  • create team and project (for instance on this repo, or a clone of it)
  • commit a change to e.g. this branch
  • trigger a prebuild (e.g., from the "branches" view on this branch): ... -> "run prebuild"
  • in a new tab, go to the same branches view, and hit "new workspace"
  • observe how in both places you:
    • don't see the prebuild status
    • but you still see the "Skip Prebuild" button

Release Notes

always show buttons in the prebuild logs view

Documentation

Werft options:

  • /werft with-preview

@roboquat roboquat added size/M and removed size/S labels Jul 5, 2022
@roboquat roboquat added size/L and removed size/M labels Jul 5, 2022
@geropl
Copy link
Member Author

geropl commented Jul 5, 2022

/hold Because of this TEST COMMIT

@geropl geropl marked this pull request as ready for review July 5, 2022 15:47
@geropl geropl requested a review from a team July 5, 2022 15:47
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 5, 2022
@laushinka
Copy link
Contributor

laushinka commented Jul 6, 2022 •
edited by werft-gitpod-dev-com bot

Thanks! Tested and works as advertised 💪🏼

laushinka
laushinka approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@laushinka laushinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a reminder to revert the test commit

@geropl
Copy link
Member Author

geropl commented Jul 6, 2022

/unhold test commit is no more ✔️

@geropl
Copy link
Member Author

geropl commented Jul 6, 2022

/unhold

@roboquat roboquat merged commit c5e1e01 into main Jul 6, 2022
@roboquat roboquat deleted the gpl/11148-prelogs branch July 6, 2022 09:39
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Never get stuck in dead end in PrebuildLogs view
3 participants
@geropl @laushinka @roboquat