ws-manager: Replace backup/restore success with total metric #11158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagor999
reviewed
Jul 5, 2022
ArthurSens
force-pushed
the
as/ws-backup-total-metrics
branch
from
5c0a65d
to
e5391ab
Compare
sagor999
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
LGTM, thank you!!
/hold
adding hold, can you please double check that we are not using that metric in any of grafana dashboards? As in that case they will become broken. I don't think we do, but if you could double check that would be appreciated. Feel free to remove the hold.
鉂わ笍
|
I've looked at Workspace success criteria, and couldn't find anything 馃 |
jenting
reviewed
Jul 5, 2022
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
as/ws-backup-total-metrics
branch
from
e5391ab
to
6c1b349
Compare
|
We only use the /unhold |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey Workspace-team!
We noticed that you want to level up your game towards success-criteria-related metrics, and there is momentum in the company to start adopting SLOs to get the right metrics.
We from the platform-team are being a little more proactive regarding implementing SLOs and while trying to get the first example up and running, we noticed that your metrics for workspace backups and workspace restores are a bit out of best practices for SLOs with Prometheus 馃槵
When implementing success ratio SLOs, we usually look for metrics that represent "total amount of requests" and "amount of failed requests". So the calculation looks like this:
backup error ratio = amount of backup with errors / total amount of backupsWould it be fine if we change the current metrics to be more SLO-friendly?
PS: I also simplified the nested ifs by using
WithLabelValuesinstead ofGetMetricWithLabelValuesas wellRelated Issue(s)
Fixes #
How to test
Release Notes